Repository navigation
Listing, files and navigation (#66, Part 5) - #71
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gnal (#66, 5.4) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 5.6) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 5.7) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…work (#66, 5.8) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…5-listing-nav # Conflicts: # packages/onu/src/ui/primitives.test.tsx
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Part 3 of #66 (Thaana and locale): each item has a test that failed first, and gets its own commit and changeset.
useThaanaInput(options)anduseThaanaField(thaana)now return a callbackrefand attach to the element held in state, so the keyboard follows the DOM node.CommandPalette thaananow types Thaana on every open, andTextInputkeeps working afterendAddonreplaces the input. All callers were updated;useMergedReftakes a third ref.thaanaselect seeds the search with the transliterated key (ކ), using the configured keymap. It stays Latin whendefaultEnabled: false.isLatinKeyboardTextnow accepts tabs and line breaks, sopaste: "transliterate"converts multi-line pastes.onToggleis given,attachThaanaKeyboardpasses it the requested state and leaves the change to the owner. The hook applies it through its own (controlled or uncontrolled) state, so a parent that keepsenabled={true}no longer leaves the field RTL with Latin typing. WithoutonToggle, the shortcut still flips the mode itself.i18n/format.tscallsregisterEnglish({ common }).english-registry.test.tsno longer skipsi18n/.dayPeriodnow maps midnight, night and morning to AM and noon, afternoon and evening to PM.match.dayparses full, short and narrow names, trying the longest name first.listing.actionRecordTitle(en"{action} {name}?", dv"{name} {action}؟"). Only deletes add "This can't be undone."ChartTooltipContentdefault formatter usesuseFormatNumber, andDataTableDatecells useuseFormatDate, instead of the browser locale.OnuProviderretries a failed on-demand locale load after 1, 3 and 10 s, then once more on the browser'sonlineevent.Skipped ([P] / device check)
Could not reproduce
Behaviour and API changes worth noting
useThaanaInput(ref, options)is nowuseThaanaInput(options), returning{ ref, enabled, setEnabled, toggle }.useThaanaField(ref, thaana)is nowuseThaanaField(thaana), returning{ ref, … }(refisundefinedwhenthaanais falsy). The docs (guides/thaana-input,text-inputs/thaana-toggle) and the demo are updated.attachThaanaKeyboard'sonTogglenow means "the shortcut asks for this state". CallsetEnabledto apply it.listing.actionRecordTitle(en and dv). Non-delete confirm dialogs no longer have a default description.Verification
pnpm lint,pnpm format:check,pnpm typecheck: passvitest run --maxWorkers=3(full library suite): 198 files, 2874 passed, 1 skippedvitest run --coverage src/thaana: everysrc/thaanafile is at 100% lines, branches, functions and statementsnode scripts/check-docs.mjs: Docs OKpnpm build: pass.pnpm --filter @javaabu/onu size: all budgets pass, none raised.🤖 Generated with Claude Code